Skip to content

script: check link format in nested mediawiki files#2199

Merged
jonatack merged 2 commits into
bitcoin:masterfrom
reflecttypefor:master
Jun 26, 2026
Merged

script: check link format in nested mediawiki files#2199
jonatack merged 2 commits into
bitcoin:masterfrom
reflecttypefor:master

Conversation

@reflecttypefor

Copy link
Copy Markdown
Contributor

Update the link format check to scan nested .mediawiki files as well as top-level BIP files.

Signed-off-by: reflecttypefor <reflecttypefor@outlook.com>
@jonatack jonatack added the CI label Jun 17, 2026

@jonatack jonatack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your proposal. Are there any nested mediawiki files? (I don't think we have any.)

@reflecttypefor

Copy link
Copy Markdown
Contributor Author

Thanks for your proposal. Are there any nested mediawiki files? (I don't think we have any.)

Yes, there are currently 5 nested mediawiki files:

  • bip-0008/assignments.mediawiki
  • bip-0009/assignments.mediawiki
  • bip-0016/qa.mediawiki
  • bip-0070/extensions.mediawiki
  • bip-0174/type-registry.mediawiki

There are 197 top-level .mediawiki files and 202 .mediawiki files in total. So the current script only checks the top-level files and misses these nested ones.

Comment thread scripts/link-format-chk.sh Outdated
Signed-off-by: reflecttypefor <reflecttypefor@outlook.com>
@reflecttypefor

Copy link
Copy Markdown
Contributor Author

@jonatack Please review it again. If there's anything need I to do, please feel free to let me know. 😄

@jonatack

Copy link
Copy Markdown
Member

Thanks @reflecttypefor for updating, will circle back soon to review.

@jonatack jonatack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 067b06a

@jonatack jonatack merged commit 764f75e into bitcoin:master Jun 26, 2026
4 checks passed
@jonatack

Copy link
Copy Markdown
Member

As a follow-up, feel free to open a pull request to check for MediaWiki-formatted links inside Markdown (.md) files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants