Skip to content

Fixes a race condition in test_push_consumer (test_conn_push2.cpp) #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anarthal merged 1 commit into from
Jun 20, 2026
Merged

Fixes a race condition in test_push_consumer (test_conn_push2.cpp) #430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion test/test_conn_push2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,12 @@ void test_push_consumer()
if (ec) {
BOOST_TEST_EQ(ec, net::error::operation_aborted);
push_consumer_finished = true;
resp.clear();
return;
} else if (!conn.will_reconnect()) {
// The connection might be cancelled after async_receive2 is scheduled
// for completion, but before the callback is called. An equivalent clause
// is also present in the examples.
push_consumer_finished = true;
return;
}
launch_push_consumer();
Expand Down