Skip to content

add gemini embeddings to proxy#781

Merged
Ken Jiang (knjiang) merged 1 commit into
mainfrom
06-12-add_gemini_embeddings_to_proxy
Jun 13, 2026
Merged

add gemini embeddings to proxy#781
Ken Jiang (knjiang) merged 1 commit into
mainfrom
06-12-add_gemini_embeddings_to_proxy

Conversation

@knjiang

Copy link
Copy Markdown
Contributor

No description provided.

@vercel

vercel Bot commented Jun 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ai-proxy Ready Ready Preview, Comment Jun 12, 2026 9:12pm

Request Review

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0833c5cff9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Comment on lines +6218 to +6219
"format": "google",
"flavor": "embedding",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add Google embedding routing before advertising these models

These new embedding entries make the models selectable for the standard /embeddings path, but format: "google" currently routes non-native Google URLs through fetchGoogleChatCompletions; that code expects messages and calls oaiMessages.find(...), while embedding requests send input, so /embeddings requests for gemini-embedding-2/gemini-embedding-001 fail locally instead of reaching Google's embed endpoint. Please either implement the Google embedding translation path or avoid advertising these models as usable embeddings until that route exists.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't worry codex, i have a PR to resolve ur worries

@knjiang Ken Jiang (knjiang) merged commit 4980dd0 into main Jun 13, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants