ENT-14112: Converted bare URLs into clickable links#3677
Conversation
|
@cf-bottom jenkins please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/65/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-65/output/_site/ |
|
@cf-bottom jenkins please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/66/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-66/output/_site/ |
|
@cf-bottom jenkins please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/67/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-67/output/_site/ |
aleksandrychev
force-pushed
the
ENT-14112
branch
2 times, most recently
from
9b45863 to
a18fb4e
Compare
|
@cf-bottom jenkins please |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/72/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-72/output/_site/ |
olehermanse
left a comment
olehermanse
left a comment
There was a problem hiding this comment.
Code looks good and seems to work correctly. I am missing a couple of comments and references to future devs finding this script :)
| unsafe = true # Allow HTML in md files | ||
|
|
||
| # Automatically convert bare URLs into clickable links | ||
| # linkify skips IP addresses, which are handled by pre-process scripts |
There was a problem hiding this comment.
Here I think you should add the name of that specific script
| @@ -0,0 +1,93 @@ | |||
| import re | |||
There was a problem hiding this comment.
Here I think you should add a docstring explaining what this script does, along with any important details. For example does it look for URLs anywhere? Only when they are on their own line? Inside code blocks?
Ticket: ENT-14112 Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
aleksandrychev
force-pushed
the
ENT-14112
branch
from
a18fb4e to
d2b969c
Compare
|
@olehermanse please merge |
3 participants
Ticket: ENT-14112