-
Notifications
You must be signed in to change notification settings - Fork 454
feat(clerk-js,ui): Add OAuth transport support for external auth flows #8831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
82c783b
feat(ui): add oauth transport support for external auth flows
wobsoriano 78d0941
Merge branch 'main' into rob/USER-5494-poc
wobsoriano 09fcb3b
chore: bundlewatch fix
wobsoriano b72cdc0
Merge branch 'main' into rob/USER-5494-poc
wobsoriano 871776e
Merge branch 'main' into rob/USER-5494-poc
wobsoriano a99dfe9
Merge branch 'main' into rob/USER-5494-poc
wobsoriano 4de6c93
fix types
wobsoriano 469b4d0
fix(ui): harden OAuth connected account transport
wobsoriano c5b63f3
fix(repo): harden OAuth transport callbacks
wobsoriano 4af9a42
chore: clean up
wobsoriano 55cfe31
lint fix
wobsoriano 4cc16f1
chore: add Fable comments
wobsoriano 274afa9
chore: clean up premount method
wobsoriano 4f2f877
typedoc fix
wobsoriano d78eb27
chore: clean up vars
wobsoriano 5d67cff
Merge branch 'main' into rob/USER-5494-poc
wobsoriano 229b47a
chore: remove wouldReplayStaleRedirect behavior
wobsoriano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| '@clerk/shared': minor | ||
| '@clerk/clerk-js': minor | ||
| '@clerk/react': minor | ||
| '@clerk/ui': minor | ||
| --- | ||
|
|
||
| Add internal OAuth transport support for native desktop SDK wrappers to run Clerk's prebuilt OAuth flows through a system browser. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If no transport is registered, the existing redirect behavior is preserved. If a transport is registered, we reuse the same private
authenticateWithRedirectOrPopupinitiation path through_authenticateWithTransport