chore(electron): Scaffold electron package#8855
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: a59b309 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 WalkthroughWalkthroughThis PR scaffolds a new ChangesElectron Package Scaffold
🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Comment |
There was a problem hiding this comment.
intentionally leaving blank and rely on snapshot versions only
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/electron/src/index.ts (1)
1-1: ⚡ Quick winDocument the exported package constant.
clerkElectronis a public surface symbol, so it should carry a short JSDoc comment if it is meant to appear in generated reference docs. As per coding guidelines, public APIs underpackages/**/src/**/*are customer-facing documentation.♻️ Proposed fix
+/** Identifier for the Electron package. */ export const clerkElectron = 'electron';🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/electron/src/index.ts` at line 1, Exported public constant clerkElectron lacks JSDoc; add a short JSDoc comment above the exported symbol to document its purpose and usage so it appears in generated reference docs. Locate the export named clerkElectron in packages/electron/src/index.ts and add a one- or two-line /** ... */ comment describing that it is the package identifier for the Electron integration (e.g., purpose and that it’s a public surface symbol).Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/electron-package-scaffold.md:
- Around line 1-2: The changeset file .changeset/electron-package-scaffold.md
currently contains only delimiters and must be populated so the new package
`@clerk/electron` is included in the release flow; edit that file to add a proper
changeset entry naming the package "`@clerk/electron`", specify the appropriate
release type (patch/minor/major) and a short summary of the change so a version
bump and changelog entry are generated during release.
---
Nitpick comments:
In `@packages/electron/src/index.ts`:
- Line 1: Exported public constant clerkElectron lacks JSDoc; add a short JSDoc
comment above the exported symbol to document its purpose and usage so it
appears in generated reference docs. Locate the export named clerkElectron in
packages/electron/src/index.ts and add a one- or two-line /** ... */ comment
describing that it is the package identifier for the Electron integration (e.g.,
purpose and that it’s a public surface symbol).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 6fb8b206-eb94-4dfa-b789-70a2efe621bf
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (6)
.changeset/electron-package-scaffold.md.github/labeler.ymlpackages/electron/package.jsonpackages/electron/src/index.tspackages/electron/tsconfig.jsonpackages/electron/tsdown.config.mts
|
!snapshot |
Description
#customer-ping, our Electron SDK design partner is ready to test early, but they currently cant consume
@clerk/electronbecause the package does not exist on npm yet.This scaffolds the package so it can participate in snapshot releases. We can then give them installable snapshots.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
@clerk/electronpackage for Electron support, including package configuration, TypeScript setup, and build tooling.