Add NVMe support to Alicloud infrastructure configuration#635
Merged
aramprice merged 1 commit intoJun 11, 2026
Merged
Conversation
Contributor
WalkthroughThis pull request extends the Alicloud infrastructure configuration by adding an 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rkoster
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: this repository uses a "Merge Forward" strategy
Add nvme_support cloud property for AliCloud stemcells
AliCloud instance families (c9i, g9i, r9i) require stemcell images to have Features.NvmeSupport=supported set in ECS. Previously the CPI was enabling this unconditionally for all AliCloud stemcells, which couples infrastructure-specific behaviour to the CPI rather than to the stemcell definition.
This change adds "nvme_support": "supported" to Alicloud#additional_cloud_properties in the infrastructure definition. The value is written into cloud_properties in stemcell.MF at build time, alongside the existing root_device_name property. CPIs can read this field to decide whether to enable NVMe support when importing or copying a stemcell image, rather than inferring it from the infrastructure name.
No other infrastructure is affected.
Changes