Skip to content

Add NVMe support to Alicloud infrastructure configuration#635

Merged
aramprice merged 1 commit into
cloudfoundry:ubuntu-jammyfrom
Ivaylogi98:ubuntu-jammy-add-support-for-nvme-on-ali
Jun 11, 2026
Merged

Add NVMe support to Alicloud infrastructure configuration#635
aramprice merged 1 commit into
cloudfoundry:ubuntu-jammyfrom
Ivaylogi98:ubuntu-jammy-add-support-for-nvme-on-ali

Conversation

@Ivaylogi98

@Ivaylogi98 Ivaylogi98 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

NOTE: this repository uses a "Merge Forward" strategy

Add nvme_support cloud property for AliCloud stemcells

AliCloud instance families (c9i, g9i, r9i) require stemcell images to have Features.NvmeSupport=supported set in ECS. Previously the CPI was enabling this unconditionally for all AliCloud stemcells, which couples infrastructure-specific behaviour to the CPI rather than to the stemcell definition.

This change adds "nvme_support": "supported" to Alicloud#additional_cloud_properties in the infrastructure definition. The value is written into cloud_properties in stemcell.MF at build time, alongside the existing root_device_name property. CPIs can read this field to decide whether to enable NVMe support when importing or copying a stemcell image, rather than inferring it from the infrastructure name.

No other infrastructure is affected.

Changes

  • bosh-stemcell/lib/bosh/stemcell/infrastructure.rb — added "nvme_support" => "supported" to Alicloud#additional_cloud_properties
  • bosh-stemcell/spec/bosh/stemcell/infrastructure_spec.rb — added missing describe Infrastructure::Alicloud block with nvme_support assertion (the AliCloud infrastructure had no unit tests before this change)

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

This pull request extends the Alicloud infrastructure configuration by adding an nvme_support property set to "supported" in the additional_cloud_properties method. The implementation change returns a hash with both the existing root_device_name and the new nvme_support key. Corresponding test coverage validates that the Alicloud infrastructure correctly reports this property alongside other infrastructure attributes.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: adding NVMe support to the Alicloud infrastructure configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description comprehensively explains the purpose, context, changes, and rationale for adding nvme_support to Alicloud infrastructure configuration.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aramprice aramprice merged commit e6f4e27 into cloudfoundry:ubuntu-jammy Jun 11, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants