Guard missing contact-card clipboard helper#102
Merged
Conversation
Avoid throwing before the contact card's existing error handling when the shared utility object is present but copyToClipboard is unavailable.
There was a problem hiding this comment.
Pull request overview
This PR hardens the /contact-card/ clipboard path by ensuring the page doesn’t throw a TypeError when window.Utils exists but its copyToClipboard helper is missing, allowing the existing “copy failed” status handling to run as intended.
Changes:
- Guard the
copyToClipboardinvocation with optional-call chaining (?.(...)) so a missing helper yields a controlled failure (copiedfalsy) instead of an exception. - Preserve existing fallback status messages and control flow for both “Copy email” and “Share card” actions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
copyToClipboardmethod call inassets/js/contact-card.jsTesting
npm test -- --runInBand contact-card.test.js(6 tests passed)./scripts/lint-check.sh(passed)git diff --check(passed)Evidence