Update shimtest to v0.2.0#236
Open
dmcgowan wants to merge 4 commits into
Open
Conversation
dmcgowan
force-pushed
the
update-shimtest-0.2
branch
from
98e8557 to
1c819b5
Compare
dmcgowan
force-pushed
the
update-shimtest-0.2
branch
from
1c819b5 to
b0cfa9a
Compare
The 2-second timeout in waitTimeout was too short for large payloads: when a process exits with data still buffered in the vsock send queue, the in-VM copy goroutine may still be writing to the vsock. If waitTimeout fires before the goroutine completes, e.io.Close() closes the vsock streams while data is in flight, causing truncation. Increase to 30 seconds to match the host-side ioShutdown drain timeout. Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
The vsock stdio path writes stdout data from the VM to the host via send() on a blocking unix socket. send() can return a partial byte count without an error (short write), after which UnixProxy::sendmsg was silently discarding the unwritten remainder, causing stdout truncation. Add a retry loop that advances the buffer slice on each call and retries until the full buffer is sent. EINTR is absorbed and retried transparently; other errors break the loop as before. The patch is stored in script/patches/ and applied to libkrun during the Docker build via git apply. Signed-off-by: Derek McGowan <derek@mcg.dev>
dmcgowan
force-pushed
the
update-shimtest-0.2
branch
from
b0cfa9a to
ca01ffa
Compare
Signed-off-by: Derek McGowan <derek@mcg.dev>
dmcgowan
force-pushed
the
update-shimtest-0.2
branch
from
ca01ffa to
4703ca7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes repository rename