ci: replace broken workflows with a working build/test/lint pipeline#474
Merged
Conversation
The old project-check and daily-project-check workflows triggered on the non-existent `master` branch, ran on Node 12 with actions/checkout@v1, and called a `jest:test` script that no longer exists — so CI never ran on PRs and the daily job failed every day. Add a single CI workflow that runs on push/PR to main: - test job: build and test @coreui/react on Node 20.x and 22.x - lint job: yarn lint, non-blocking for now (a few react-hooks v7 findings and one deferred public type remain) until the remaining errors clear
setup-node's yarn cache and yarn install --frozen-lockfile both require a committed yarn.lock, which this repo gitignores. Drop the cache option and the frozen flag so install resolves from package.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI was effectively dead:
project-check.ymlanddaily-project-check.ymltrigger on themasterbranch, but the default branch ismain— so they never ran on pushes/PRs.actions/checkout@v1, and callednpm run jest:test, a script that no longer exists.Change
Replace both with a single
ci.ymlthat runs on push/PR tomain:yarn install --frozen-lockfile,yarn lib:build,yarn lib:teston a Node 20.x / 22.x matrix. Verified locally that these run green from the repo root in the same configuration CI uses (thecoreui-react-chartjs/coreui-icons-reactsubmodules are separate repos with their own release cycle and CI, so they're out of scope here).yarn lint, markedcontinue-on-error: trueso it surfaces findings without blocking merges. A handful of react-hooks v7 errors and one deferred publicItemtype remain (down from ~400 lint errors); once they clear, dropcontinue-on-errorto make lint a required check.stale.ymlis left untouched.Follow-ups
Itemitems are resolved.