fix(CCarousel): use the vanilla swipe helper for touch navigation#476
Merged
Conversation
The inline touch handling used a 5px threshold and fired mid-gesture on touchmove, with no Pointer event support and no RTL awareness. Replace it with a Swipe helper ported from vanilla @coreui/coreui (pointer events with a touch fallback, 40px threshold, detection on release), wired via a single effect that respects RTL when mapping swipe direction to prev/next.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The carousel's touch handling was a simplified inline implementation: a 5px threshold, firing mid-gesture on
touchmove, with no Pointer event support and no RTL awareness. This replaces it with a faithful port of the vanilla@coreui/coreuiswipe helper.What
utils/Swipe— Pointer events with a Touch-event fallback, a 40px threshold, detecting the gesture on release (pointerup/touchend). Mirrors the vanillautil/swipe.js.useEffect(keyed ontouch), reading the latesthandleControlClickvia a ref to avoid stale closures.dir="rtl"(matching vanilla's_directionToOrder), checked per gesture against the carousel element.No public API change — the
touchprop andonSlide/onSlidevents are unchanged; only the gesture detection is corrected.Tests & verification
utils/__tests__/swipe.spec.tscovers threshold, direction, and dispose.yarn lib:test— 365/365 passing ·yarn lib:buildOK · scoped lint clean (no new errors).