Rubocop: Fix Lint/SafeNavigationWithEmpty offenses#230
Merged
DemetrisChr merged 1 commit intoJun 22, 2026
Merged
Conversation
DemetrisChr
commented
Jun 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses RuboCop Lint/SafeNavigationWithEmpty offenses by removing &.empty? checks in conditionals, while preserving the intended behavior of options serialization and JSON transcoding. It also adds explicit test coverage for encoding/decoding JSON null.
Changes:
- Replace
&.empty?conditional checks inOptions::Getwith explicitnil/empty?guards. - Replace
blob&.empty?check inJsonTranscoder#decodewith a non-safe-navigation equivalent. - Add tests asserting
nilencodes to"null"and"null"decodes tonil.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/json_transcoder_test.rb |
Adds coverage for encoding nil and decoding JSON null. |
lib/couchbase/options.rb |
Fixes projections-related conditional logic without safe-navigation empty? usage. |
lib/couchbase/json_transcoder.rb |
Updates decode guard to avoid safe-navigation empty? in conditionals. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aea25f3 to
8b48a67
Compare
avsej
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.