Skip to content

docs: correct example code, javadoc, and cross-references#286

Merged
sgerbino merged 1 commit into
cppalliance:developfrom
sgerbino:pr/doc-pass
Jun 21, 2026
Merged

docs: correct example code, javadoc, and cross-references#286
sgerbino merged 1 commit into
cppalliance:developfrom
sgerbino:pr/doc-pass

Conversation

@sgerbino

Copy link
Copy Markdown
Collaborator

Align the documentation with the actual API:

  • Use capy:: for composed read/write/run and for the buffer-sequence concepts (ConstBufferSequence/MutableBufferSequence)
  • Use std:: error handling throughout (std::error_code, std::system_error, std::errc, std::system_category); io_result has no value(), so examples bind [ec, ...] and throw std::system_error on failure
  • Use corosio:: address types and the error_code parse API in place of Boost.URL
  • Populate tcp_server workers with set_workers(); bind and listen the acceptor as separate steps or via the convenience constructor
  • Fix the TLS examples: flat tls_* enums, pointer-form stream construction with a tls_context, and a separate tls_stream& path
  • Correct factual details: socket_option::no_delay, the io_context concurrency-hint clamp, signal_set remove()/clear() signatures, the local_endpoint path limit, and the Boost dependency list

Apply the same corrections to the header javadoc @code examples in resolver, tls_context, and io_stream.

Qualify same-directory page cross-references so Antora resolves them.

@cppalliance-bot

cppalliance-bot commented Jun 20, 2026

Copy link
Copy Markdown

An automated preview of the documentation is available at https://286.corosio.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-06-21 01:28:52 UTC

@cppalliance-bot

cppalliance-bot commented Jun 20, 2026

Copy link
Copy Markdown

GCOVR code coverage report https://286.corosio.prtest3.cppalliance.org/gcovr/index.html
LCOV code coverage report https://286.corosio.prtest3.cppalliance.org/genhtml/index.html
Coverage Diff Report https://286.corosio.prtest3.cppalliance.org/diff-report/index.html

Build time: 2026-06-21 01:35:41 UTC

@codecov

codecov Bot commented Jun 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.90%. Comparing base (6608ddd) to head (4dda817).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #286   +/-   ##
========================================
  Coverage    77.90%   77.90%           
========================================
  Files           96       96           
  Lines         7160     7160           
  Branches      1751     1751           
========================================
  Hits          5578     5578           
  Misses        1078     1078           
  Partials       504      504           
Files with missing lines Coverage Δ
include/boost/corosio/io/io_stream.hpp 81.81% <ø> (ø)
include/boost/corosio/resolver.hpp 95.06% <ø> (ø)
include/boost/corosio/tcp_acceptor.hpp 91.83% <ø> (ø)
include/boost/corosio/tcp_server.hpp 80.86% <ø> (ø)
include/boost/corosio/timer.hpp 100.00% <ø> (ø)
include/boost/corosio/tls_context.hpp 100.00% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6608ddd...4dda817. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sgerbino sgerbino force-pushed the pr/doc-pass branch 2 times, most recently from 839dae8 to 1b06a2e Compare June 21, 2026 01:10
Align the documentation with the actual API:

- Use capy:: for composed read/write/run and for the buffer-sequence
  concepts (ConstBufferSequence/MutableBufferSequence)
- Use std:: error handling throughout (std::error_code, std::system_error,
  std::errc, std::system_category); io_result has no value(), so examples
  bind [ec, ...] and throw std::system_error on failure
- Use corosio:: address types and the error_code parse API in place of
  Boost.URL
- Populate tcp_server workers with set_workers(); bind and listen the
  acceptor as separate steps or via the convenience constructor
- Fix the TLS examples: flat tls_* enums, pointer-form stream construction
  with a tls_context, and a separate tls_stream& path
- Correct factual details: socket_option::no_delay, the io_context
  concurrency-hint clamp, signal_set remove()/clear() signatures, the
  local_endpoint path limit, and the Boost dependency list

Apply the same corrections to the header javadoc @code examples in
resolver, tls_context, and io_stream.

Qualify same-directory page cross-references so Antora resolves them.
@sgerbino sgerbino merged commit c05c43b into cppalliance:develop Jun 21, 2026
42 checks passed
@sgerbino sgerbino deleted the pr/doc-pass branch June 21, 2026 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants