Skip to content

Fix #14847 Function pointer argument triggers false positive funcArgNamesDifferentUnnamed #8653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −2
Open

Fix #14847 Function pointer argument triggers false positive funcArgNamesDifferentUnnamed #8653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fefb2ac
Update checkother.cpp
chrchr-github Jun 15, 2026
4eb93bc
Update testother.cpp
chrchr-github Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/checkother.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4043,7 +4043,7 @@ void CheckOtherImpl::checkFuncArgNamesDifferent()
definitions[j] = variable->nameToken();
}
// get the declaration (search for first token with varId)
while (decl && !Token::Match(decl, ",|)|;")) {
while (decl && !Token::Match(decl, "[,;]")) {
// skip everything after the assignment because
// it could also have a varId or be the first
// token with a varId if there is no name token
Expand All @@ -4052,7 +4052,7 @@ void CheckOtherImpl::checkFuncArgNamesDifferent()
break;
}
// skip over templates and arrays
if (decl->link() && decl->str() != "(")
if (decl->link() && !Token::Match(decl, "[()]"))
decl = decl->link();
else if (decl->varId())
declarations[j] = decl;
Expand Down
4 changes: 4 additions & 0 deletions test/testother.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12955,6 +12955,10 @@ class TestOther : public TestFixture {
"[test.cpp:1:12]: (style, inconclusive) Function 'f' argument 1 names different: declaration 'a' definition '<unnamed>'. [funcArgNamesDifferentUnnamed]\n"
"[test.cpp:4:12]: (style, inconclusive) Function 'g' argument 1 names different: declaration '<unnamed>' definition 'b'. [funcArgNamesDifferentUnnamed]\n",
errout_str());

check("void f(void (*fp)(), int x);\n" // #14847
"void f(void (*fp)(), int x) {}\n");
ASSERT_EQUALS("", errout_str());
}

void funcArgOrderDifferent() {
Expand Down
Loading