Add TestServer.TCP#58
Open
richard-ash wants to merge 1 commit into
Open
Conversation
danschultzer
force-pushed
the
richard/add-ssh
branch
from
dc7e815 to
c76044f
Compare
richard-ash
force-pushed
the
richard/add-tcp
branch
5 times, most recently
from
75c5759 to
4e3d05e
Compare
richard-ash
force-pushed
the
richard/add-tcp
branch
3 times, most recently
from
1e0893b to
4f7a37d
Compare
richard-ash
force-pushed
the
richard/add-tcp
branch
2 times, most recently
from
77b349d to
b77449c
Compare
richard-ash
force-pushed
the
richard/add-tcp
branch
3 times, most recently
from
f5fca44 to
b796fa9
Compare
danschultzer
reviewed
Jun 2, 2026
danschultzer
reviewed
Jun 2, 2026
danschultzer
reviewed
Jun 2, 2026
richard-ash
force-pushed
the
richard/add-tcp
branch
from
b796fa9 to
ca2fc2c
Compare
danschultzer
reviewed
Jun 4, 2026
danschultzer
reviewed
Jun 4, 2026
danschultzer
reviewed
Jun 4, 2026
danschultzer
reviewed
Jun 4, 2026
Comment on lines
+59
to
+62
| @spec connections(TestServer.instance()) :: [map()] | ||
| def connections(instance) do | ||
| GenServer.call(instance, :connections) | ||
| end |
Collaborator
Author
There was a problem hiding this comment.
Yea we use this in a couple places to get all connections
danschultzer
reviewed
Jun 4, 2026
danschultzer
reviewed
Jun 4, 2026
danschultzer
reviewed
Jun 4, 2026
danschultzer
reviewed
Jun 4, 2026
danschultzer
reviewed
Jun 4, 2026
Comment on lines
+136
to
+141
| state.connections | ||
| |> Enum.reduce(state, fn connection, state -> | ||
| connection | ||
| |> run_send_handler(to, stacktrace) | ||
| |> send_response(connection, state) | ||
| end) |
Owner
There was a problem hiding this comment.
This reads odd, why run it on all connections instead of just having this being single connection in the first place? I guess we can support multi connections but if we do that we should make it more explicit.
richard-ash
force-pushed
the
richard/add-tcp
branch
4 times, most recently
from
6a8914a to
0fb1390
Compare
richard-ash
force-pushed
the
richard/add-tcp
branch
2 times, most recently
from
8857c9f to
292d6a8
Compare
richard-ash
force-pushed
the
richard/add-tcp
branch
3 times, most recently
from
6d56e25 to
7c2290b
Compare
richard-ash
force-pushed
the
richard/add-tcp
branch
from
7c2290b to
d01935b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.