backport: Merge bitcoin#29041

[thepastaclaw]

backport: Merge bitcoin#29041

Issue being fixed or feature implemented

• Replaces backport: Merge bitcoin#29041 #7190 with the independent test: fix intermittent error in rpc_net.py (#29030) bitcoin/bitcoin#29041 backport only.
• Fixes an intermittent rpc_net.py race where waiting for the
  "Added connection peer=" debug log does not guarantee the new peer is
  already visible through getpeerinfo().
• Intentionally does not include test: detect OS in functional tests consistently using platform.system() bitcoin/bitcoin#29034 from the original PR title.
  Review on backport: Merge bitcoin#29041 #7190 noted test: detect OS in functional tests consistently using platform.system() bitcoin/bitcoin#29034 depends on prerequisite context,
  including Nuke adjusted time from validation (attempt 2) bitcoin/bitcoin#28956, so this replacement keeps that separate instead of
  backporting an incomplete fragment.

What was done?

• Backported test: fix intermittent error in rpc_net.py (#29030) bitcoin/bitcoin#29041:
  • test: fix intermittent error in rpc_net.py (#29030)
• Replaced the debug-log wait with the existing wait_for_new_peer() helper
  from the already-merged test: fix v2 transport intermittent test failure (#29002) bitcoin/bitcoin#29006 backport.

How Has This Been Tested?

• git diff --check upstream/develop...HEAD
• COMMIT_RANGE=upstream/develop..HEAD test/lint/lint-whitespace.py
• python3 -m py_compile test/functional/rpc_net.py
• ./autogen.sh
• ./configure --without-gui --disable-bench --disable-fuzz-binary
• make -C src/dashbls -j4
• make -C src/secp256k1 -j4
• make -C src dashd -j4
• test/functional/rpc_net.py
• code-review dashpay/dash upstream/develop takeover-7190-backport-29041

Breaking Changes

• None.

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone

[PastaPastaPasta]

utACK 5722f88; trivial

[thepastaclaw]

✅ Review complete (commit 5722f88)

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 56126cfb-0c60-4583-8080-199d748e06d8

📥 Commits

Reviewing files that changed from the base of the PR and between afe1ec5 and 5722f88.

📒 Files selected for processing (1)

• test/functional/rpc_net.py

---

Walkthrough

This change modifies a single line in the functional test file test/functional/rpc_net.py. In test_getpeerinfo, the mechanism for waiting on a new peer connection is switched from an assert_debug_log context manager checking for a specific log entry to a wait_for_new_peer() context manager, applied before adding a p2p connection without sending a version.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately identifies this as a backport merge of bitcoin#29041, which matches the change set.
Description check	✅ Passed	The description clearly matches the backported rpc_net.py race fix and explains the scope and intent of the change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}