docs(provenance): soften 'guarantee' to 'property' for make() contract#214
Merged
MilagrosMarin merged 1 commit intoJul 17, 2026
Merged
Conversation
The make() reproducibility contract is framed at autopopulate.md:322 as 'a convention — observed by discipline, not enforced.' Calling it a 'guarantee' alongside the framework-enforced FK integrity quietly conflates the two. One-word swap: 'the same guarantee' -> 'the same property'. Consistent with the section title 'Lineage as a structural property'.
dimitri-yatsenko
approved these changes
Jul 17, 2026
dimitri-yatsenko
left a comment
Member
There was a problem hiding this comment.
LGTM. 'property' is the better word here; no accuracy concern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small terminology tweak in
comparison-to-provenance-systems.md:41.The surrounding section — "Lineage as a structural property" — argues that lineage is FK-graph-shaped (framework-enforced). The make() reproducibility contract at
autopopulate.md:322, on the other hand, explicitly frames itself as "a convention — observed by discipline, not enforced."Calling both the same "guarantee" in one sentence quietly conflates FK integrity (a real framework guarantee) with the make() contract (an author-observed convention). Swap to "property" — thematically consistent with the section title, no overpromise.