dbeaver/pro#9614 add predefined param for connection type by devnaumov · Pull Request #4454 · dbeaver/cloudbeaver

devnaumov · 2026-07-07T22:13:05Z

closes 9614

codacy-production · 2026-07-07T22:14:42Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 76 complexity

Metric Results

Complexity 76

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

sergeyteleshev · 2026-07-09T08:10:37Z


  // TODO: must be loaded in place where it is used
  useResource(Body, ProjectInfoResource, CachedMapAllKey, { silent: true });
+  useResource(Body, ConnectionTypeResource, CachedMapAllKey, { silent: true });


lets load in place where it is required cause now the tracks are hot and we can do it quite easy
from my perspective inside Connection Tree should be enough, what do you think? cause this tree like is always gonna be shown despite everything and the feature is strongly sticked to it

also in administration part when we load connection types tab

The connection tree might be hidden for certain roles in TE. Later we will show types for every tree that connected to the connection, for example ai chat custom scope tree and etc. Connection types are strongly connected to the whole app as projects and we want them to be ready as soon as possible. As we will not use this resource in place where we resolve type color, it will be just useResource(Component, ConnectionTypeResource, CachedMapAllKey); in like 10 places that is confusing as well.

okay then adding it to useConnectionTypeColor.ts should be enough, I guess

Its better to now use useResource hook inside hooks that might be used inside nodes or cells as its very perfomance heavy. In our case we use it for navigation tree

sergeyteleshev · 2026-07-09T08:13:44Z

+export type NewConnectionType = ConnectionType & { [NEW_CONNECTION_TYPE_SYMBOL]: boolean; timestamp: number };
+
+@injectable(() => [GraphQLService, SessionResource])
+export class ConnectionTypeResource extends CachedMapResource<string, ConnectionType> {


I think we should outdate ConnectionInfoResource if this resource is outdated to keep things fresh

sergeyteleshev · 2026-07-09T08:24:35Z

+export function compareNewConnectionTypes(a: ConnectionType, b: ConnectionType): number {
+  if (isNewConnectionType(a) && isNewConnectionType(b)) {
+    return b.timestamp - a.timestamp;
+  }
+
+  if (isNewConnectionType(b)) {
+    return 1;
+  }
+
+  if (isNewConnectionType(a)) {
+    return -1;
+  }
+
+  return 0;
+}


what about predefined flag? do we want to consider it here as well?

This function only compares by the new flag, general sorting happens inside compare fn as we do in other resources

sergeyteleshev · 2026-07-09T09:22:46Z

+export function useConnectionTypeColor(connectionKey: IConnectionInfoParams | undefined): string | undefined {
+  const connectionTypeService = useService(ConnectionTypeService);
+
+  if (!connectionKey) {
+    return;
+  }
+
+  return connectionTypeService.getConnectionTypeColor(connectionKey);
+}


maybe here we also can use useResource for ConnectionInfoResource & ConnectionTypeResource to be sure all loaded and no cases when we try to calc color but it is not preloaded with resources

Its better to now use useResource hook inside hooks that might be used inside nodes or cells as its very perfomance heavy

sergeyteleshev · 2026-07-09T09:24:11Z


  &:not(:global([aria-selected='true'])) {
-    background-color: transparent !important;
+    background-color: transparent;


autotests required then to see if no visual regression

sergeyteleshev · 2026-07-09T09:40:00Z

-            <FolderTabRenderer key={folderId} nodeId={nodeId} folderId={folderId} parents={parents} />
-          ))}
-        </TabList>
+        <div>


why do we need div here?

Because we need background color to be applied around tabs and not on the tabs itself

sergeyteleshev · 2026-07-09T09:45:48Z

+import type { IConnectionInfoParams } from '../CONNECTION_INFO_PARAM_SCHEMA.js';
+
+@injectable(() => [ConnectionTypeResource, ConnectionInfoResource, ThemeService])
+export class ConnectionTypeService {


you have 2 ways to calculate colors now:

This service

useConnectionTypeColor hook

both has similar interface. you need a connectionKey to keep things going
both cases uses hook and the service for tsx components

seems like you can just use the hook and pass to it something like:
{connectionId?: string, projectId?: string} - and handle edge case if nothing is provided inside the hook to avoid these if/else clauses you have for service case of implementation

so smells like we can just remove this service and move all of its logic inside the hook

We cant, there might be cases where you need this color in some service or not in react context in general. When all your logic inside hook, you can only use it inside components. Also in some places we dont use hook (for example when you cant use it cause you cant use hooks conditionally), there we get color from service. So the service is source of truth here

sergeyteleshev · 2026-07-09T09:47:13Z

    "@cloudbeaver/core-root": "workspace:*",
    "@cloudbeaver/core-sdk": "workspace:*",
    "@cloudbeaver/core-settings": "workspace:*",
+    "@cloudbeaver/core-theming": "workspace:*",


pls create PR for widgets repo

yagudin10 and others added 2 commits July 7, 2026 09:51

dbeaver/pro#9614 add predefined param for connection type

2ee7a6c

Merge branch 'devel' into dbeaver/pro#9614-connection-types

678649f

devnaumov and others added 3 commits July 8, 2026 00:34

dbeaver/pro#9614 add connection type selector

46b41b2

Merge branch 'devel' into dbeaver/pro#9614-connection-types

97ae78e

dbeaver/pro#9614 make menu indicator more visible

a9c49b1

devnaumov requested review from SychevAndrey and sergeyteleshev July 8, 2026 13:46

dbeaver/pro#9614 add extra colors

060a708

sergeyteleshev reviewed Jul 9, 2026

View reviewed changes

dbeaver/pro#9614 outdate connections

9ce1827

devnaumov requested a review from sergeyteleshev July 9, 2026 15:04

dbeaver/pro#9614 load types in bootstrap phrase

1d119e0

Uh oh!

Conversation

devnaumov commented Jul 7, 2026

Uh oh!

codacy-production Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Up to standards ✅

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devnaumov Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devnaumov Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devnaumov Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codacy-production Bot commented Jul 7, 2026 •

edited

Loading

devnaumov Jul 9, 2026 •

edited

Loading

devnaumov Jul 9, 2026 •

edited

Loading

devnaumov Jul 9, 2026 •

edited

Loading