Unused analyzers: disable in VS when file has errors#19892
Merged
Conversation
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
|
github-actions
Bot
added
the
AI-Tooling-Check-Scanned-Clean
auduchinok
added
NO_RELEASE_NOTES
Member
Author
|
@T-Gro This is ready. Feel free to add VS-specific tests to this branch, like the ones in the other PR. |
Member
|
OK I agree this is better if VS is the only editor interested into it 👍 . Thank you! |
T-Gro
approved these changes
Jun 12, 2026
github-project-automation
Bot
moved this from New
to In Progress
in F# Compiler and Tooling
github-project-automation
Bot
moved this from In Progress
to Done
in F# Compiler and Tooling
This was referenced Jun 12, 2026
T-Gro
added a commit
that referenced
this pull request
Jun 15, 2026
Branch was behind main again. Auto-merge resolved IlxGen.fs, Optimizer.fs, TypedTreeOps.ExprConstruction.fs, and one baseline cleanly. Verified post-merge: SEQ=PAR FCS.dll byte-identical, sin/abs quotation passes. (#19928) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alternative take on #19854.
The FCS APIs work correctly with the check results they are passed in, so the decision on whether to call them should be done on the client side.