illustrate all iterations for gcperfsim#5248
Open
VincentBu wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GCPerfSim analyze output pipeline to include per-iteration metric values in the markdown results, alongside both “original” and outlier-corrected averages, so analysis can illustrate all iterations rather than only aggregated values.
Changes:
- Tighten analysis/presentation method signatures to accept
IReadOnlyCollection<GCTraceMetricComparisonResults>for GCPerfSim analyze output. - Update GCPerfSim markdown generation to emit per-metric tables that include per-iteration values and both original/corrected averages.
- Extend
GCTraceMetricComparisonResultwith “original” average/delta/percentage-delta properties for reporting.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure/Commands/GCPerfSim/GCPerfSimAnalyzeCommand.cs | Adjusts presentation API to accept an IReadOnlyCollection of grouped comparison results. |
| src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure.Core/Presentation/GCPerfSim/Markdown.cs | Reworks markdown output to show per-iteration values and adds new per-metric table generation helpers. |
| src/benchmarks/gc/GC.Infrastructure/GC.Infrastructure.Core/Analysis/GCTraceMetricComparisonResult.cs | Adds original-average/delta properties used by the new markdown output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables illustrating results from all iterations for gcperfsim test.