(Blocked on #110) xbescanner: Adds mechanism to load save game icons.#124
Draft
abaire wants to merge 1 commit into
Draft
(Blocked on #110) xbescanner: Adds mechanism to load save game icons.#124abaire wants to merge 1 commit into
abaire wants to merge 1 commit into
Conversation
Owner
|
I really like the idea of this, but I fear it might slow down hw renderer progress significantly. |
Contributor
Author
|
No problem, given that the framerate is already quite low on hardware I think it's entirely reasonable to let this sit until accelerated rendering is available. Hopefully we can also render the DXT1 textures without having to decompress them as well. |
abaire
force-pushed
the
retrieves_save_icons
branch
from
September 26, 2021 15:15
efdc8a0 to
9130453
Compare
abaire
marked this pull request as draft
September 26, 2021 15:16
Contributor
Author
|
Putting in draft until #110 is resolved |
abaire
changed the title
abaire
force-pushed
the
retrieves_save_icons
branch
4 times, most recently
from
October 7, 2021 14:19
7395885 to
85d4a27
Compare
abaire
force-pushed
the
retrieves_save_icons
branch
from
October 7, 2021 14:22
85d4a27 to
50f2929
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought it might be interesting to show the save game icon for either all of the XBEs or the actively selected one. This puts in the infrastructure to make this possible (I'll send a draft PR with a really ugly proof-of-concept shortly).