fix: allow update workflow PRs to trigger CI#104
Open
LeonidasZhak wants to merge 1 commit into
Open
Conversation
Author
|
Thanks, that I rechecked the branch locally today:
The check result is still the repository baseline: 1 WARNING and 2 NOTEs for the CC0 license string, top-level The current failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Let the reusable
update-to-latest-easystatsworkflow use an optional caller-supplied token when it creates dependency update PRs.Thanks to maintainers
Thanks for maintaining these shared workflows. The issue report and
datawizard#640example made the failure mode clear.Issue or motivation
Closes #83. PRs created with the default
GITHUB_TOKENdo not trigger the usualpull_requestorpushworkflows, so the automated dependency-update PR can appear without CI checks.Root cause
The workflow always passed
secrets.GITHUB_TOKENtopeter-evans/create-pull-request. GitHub suppresses most workflow events caused byGITHUB_TOKEN, which prevents the generated PR from starting the package CI.Change
EASYSTATS_BOT_TOKENsecret on the reusable workflow.create-pull-requestwhen callers provide it, withgithub.tokenas the fallback to preserve current behavior.README.Rmdand regenerateREADME.md.Tests
actionlint .github/workflows/update-to-latest-easystats.yamlRscript -e 'rmarkdown::render("README.Rmd", quiet = TRUE)'R CMD build .R CMD check --no-manual workflows_0.1.0.tar.gzR CMD checkreports the same pre-existing 1 WARNING and 2 NOTEs onorigin/mainand on this branch: the CC0 license string,LICENSEtop-level note, and.githubhidden-directory note.Scope
This only changes the token used to create the automated dependency PR and the README note for callers. It does not change the dependency-update logic, branch naming, PR title/body, labels, or any general-purpose workflow.