fix: Remove Android SDK dependency#297
Closed
lurtz wants to merge 2 commits into
Closed
Conversation
rules_jvm_external introduce an Android SDK dependency to the QNX build as can be seen with eclipse-score/inc_someip_gateway#164, which fixes the QNX build. However I do not know, if making rules_jvm_external a dev_dependency will break other users of tooling.
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Bazel module dependency classification for rules_jvm_external so it is treated as a development-only dependency, aiming to avoid pulling Android SDK–related dependencies into downstream/QNX builds when this module is consumed as a dependency.
Changes:
- Mark
rules_jvm_externalasdev_dependency = TrueinMODULE.bazel. - Mark the
mavenmodule extension usage (use_extension(...)) asdev_dependency = Trueas well.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lurtz
changed the title
This was referenced Jun 26, 2026
Contributor
Author
|
Closing in favor of eclipse-score/cicd-workflows#129 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rules_jvm_external introduces an Android SDK dependency to the QNX build as can be seen with eclipse-score/inc_someip_gateway#164, where the build is fixed. By default an Android SDK is present on the runners, except when more-disk-space is used, which is here the case.
The downgrade to an earlier version removes it for the time being.
It is also unclear to me why only in CI the Android SDK dependency is present.