Skip to content

Add execution block hashes in chain reorg SSE#585

Draft
bharath-123 wants to merge 2 commits into
ethereum:masterfrom
bharath-123:update-chain-reorg-sse
Draft

Add execution block hashes in chain reorg SSE#585
bharath-123 wants to merge 2 commits into
ethereum:masterfrom
bharath-123:update-chain-reorg-sse

Conversation

@bharath-123
Copy link
Copy Markdown
Contributor

With gloas, there can be a payload reorg where the beacon block stays the same but the payload associated with the block changes.

It might make sense to add the old and new execution block hashes of the head blocks in the chain_reorg event

@nflaig nflaig added the Gloas api's needed in Gloas fork. label Mar 11, 2026
@michaelsproul
Copy link
Copy Markdown
Contributor

This approach is similar to option 3 from:

@nflaig
Copy link
Copy Markdown
Member

nflaig commented Mar 12, 2026

This approach is similar to option 3 from:

I am not in favor of option 3. there but I think adding new fields to this event is fine as they are distinct from existing fields.

@nflaig
Copy link
Copy Markdown
Member

nflaig commented Mar 25, 2026

but the payload associated with the block changes.

what exactly do you mean here? the payload associated with a beacon block will always be the same based on bid.block_hash but a payload reorg can happen where it changes from FULL to EMPTY (or vice versa)

or do you mean we should emit chain_reorg also if a payload reorg happens? in that case I think the meaning of depth becomes overloaded

Maybe it's best if we add a separate event for payload reorgs which is emitted when the beacon block is unchanged and only the payload status / EL head changes.

@michaelsproul
Copy link
Copy Markdown
Contributor

I think using the same reorg event for block/payload reorgs is OK, so long as we specify that the depth relates only to the beacon block depth.

In a sense the block_hash for an empty slot is the most recently applied payload, the hash of which is easy to obtain from block.signed_execution_payload_bid.message.parent_block_hash.

Is that what you had in mind @bharath-123?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gloas api's needed in Gloas fork.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants