fix: preserve non-null assertion dependencies in compiler#36709
fix: preserve non-null assertion dependencies in compiler#36709scarab-systems wants to merge 1 commit into
Conversation
|
Hi @scarab-systems! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
🤖 AI Code ReviewOverall Score: 0.0/10 AI review generation failed. Failed to parse AI response: Unexpected character ('/' (code 47)): maybe a (non-standard) comment? (not recognized as one since Feature 'ALLOW_COMMENTS' not enabled for parser)
|
Summary
Fixes #33054.
React Compiler preserves TypeScript non-null expressions through HIR/codegen, but non-null assertions still needed dependency/effect handling so property reads inside callbacks are not evaluated during render.
This updates the non-null expression handling so it is treated as an assign-through value for mutation/aliasing effects, and adds regression coverage for a non-null assertion inside an event handler.
How did you test this change?
yarn prettier-checkyarn lincyarn flow dom-nodecd compiler && yarn snap:buildcd compiler && yarn snap -p non-null-assertion-event-handlercd compiler && yarn snap -p non-null-expressioncd compiler && yarn snap -p non-null-assertion