Pin build to windows 2022#1866
Merged
Merged
Conversation
The latest windows github runner windows 2026 comes with visual studio 18. Which need an updated version of Cmake (4.2+) to work. The generators concept introduced does not work with older version of cmake. Firestore still depend on Cmake 3.x feature so we cannot update Cmake While we wait for firestore updates pin windows to 2022 version .
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the GitHub Actions matrix configuration in scripts/gha/print_matrix_configuration.py to explicitly use the windows-2022 runner instead of windows-latest across multiple test configurations, including Android and integration tests. There are no review comments, and I have no additional feedback to provide.
a-maurice
approved these changes
Jun 9, 2026
Pin build to windows 2022 The latest windows github runner windows 2026 comes with visual studio 18. Which need an updated version of Cmake (4.2+) to work. The generators concept introduced does not work with older version of cmake. Firestore still depend on Cmake 3.x feature so we cannot update Cmake While we wait for firestore updates pin windows to 2022 version .
Integration test with FLAKINESS (succeeded after retry)Requested by @AustinBenoit on commit 01c4566
Add flaky tests to go/fpl-cpp-flake-tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The latest windows github runner windows 2026 comes with visual studio 18. Which need an updated version of Cmake (4.2+) to work. The generators concept introduced does not work with older version of cmake. Firestore still depend on Cmake 3.x feature so we cannot update Cmake While we wait for firestore updates pin windows to 2022 version.
See actions/runner-images#14017 for more details
Testing
Run github runners
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.