Skip to content

Pin build to windows 2022#1866

Merged
AustinBenoit merged 2 commits into
mainfrom
fixwin
Jun 9, 2026
Merged

Pin build to windows 2022#1866
AustinBenoit merged 2 commits into
mainfrom
fixwin

Conversation

@AustinBenoit

@AustinBenoit AustinBenoit commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

The latest windows github runner windows 2026 comes with visual studio 18. Which need an updated version of Cmake (4.2+) to work. The generators concept introduced does not work with older version of cmake. Firestore still depend on Cmake 3.x feature so we cannot update Cmake While we wait for firestore updates pin windows to 2022 version.

See actions/runner-images#14017 for more details


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Run github runners


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

The latest windows github runner windows 2026 comes with
visual studio 18. Which need an updated version of Cmake (4.2+) to work.
The generators concept introduced does not work with older version of cmake.
Firestore still depend on Cmake 3.x feature so we cannot update Cmake
While we wait for firestore updates pin windows to 2022 version .
@AustinBenoit AustinBenoit added the skip-release-notes Skip release notes check label Jun 9, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the GitHub Actions matrix configuration in scripts/gha/print_matrix_configuration.py to explicitly use the windows-2022 runner instead of windows-latest across multiple test configurations, including Android and integration tests. There are no review comments, and I have no additional feedback to provide.

@AustinBenoit AustinBenoit requested a review from a-maurice June 9, 2026 16:22
Pin build to windows 2022

The latest windows github runner windows 2026 comes with
visual studio 18. Which need an updated version of Cmake (4.2+) to work.
The generators concept introduced does not work with older version of cmake.
Firestore still depend on Cmake 3.x feature so we cannot update Cmake
While we wait for firestore updates pin windows to 2022 version .
@AustinBenoit AustinBenoit merged commit 01c4566 into main Jun 9, 2026
33 checks passed
@github-actions github-actions Bot added the tests: in-progress This PR's integration tests are in progress. label Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Integration test with FLAKINESS (succeeded after retry)

Requested by @AustinBenoit on commit 01c4566
Last updated: Tue Jun 9 15:36 PDT 2026
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: emulator_ftl_target]
(2 failed tests)  FirestoreTest.TestQuerySnapshotEventsForChange
  ServerTimestampTest.TestServerTimestampsFailViaUpdateOnNonexistentDocument
messaging [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  FirebaseMessagingTest.TestSendMessageToToken
storage [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions Bot added the tests: succeeded This PR's integration tests succeeded. label Jun 9, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants