Skip to content

Ctrl + P shortcut works when overlay visible#696

Merged
lawsie merged 3 commits into
flipcomputing:mainfrom
lawsie:bugfix-090726
Jul 9, 2026
Merged

Ctrl + P shortcut works when overlay visible#696
lawsie merged 3 commits into
flipcomputing:mainfrom
lawsie:bugfix-090726

Conversation

@lawsie

@lawsie lawsie commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

When the scene was stopped and the play overlay visible, previously the Ctrl + P shortcut to play did not work.

image

This shortcut now works when the overlay is present, and consistently both starts the scene AND focuses the canvas. Also fixed a bug where the play button was showing up as purple and not white.

AI usage

Claude Sonnet 4.6 used throughout, approved individually by hand.

Summary by CodeRabbit

  • New Features
    • The Mod+KeyP shortcut now starts scene execution directly.
  • Bug Fixes
    • Improved the stopped-state play button icon so it matches the button’s text color on the overlay.
    • Removed an extra canvas focus step after using the shortcut for smoother interaction.

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ee070224-dedc-4dac-843e-c9e86192567e

📥 Commits

Reviewing files that changed from the base of the PR and between 57d7cfa and 7f3745f.

📒 Files selected for processing (2)
  • main/main.js
  • style.css

📝 Walkthrough

Walkthrough

The Mod+KeyP keyboard shortcut now calls executeCode() instead of focusing the render canvas after preventing default. Separately, a CSS rule was added so the play icon inside the canvas-stopped overlay inherits its button's text color.

Changes

Play shortcut and icon styling

Layer / File(s) Summary
Mod+KeyP triggers execution
main/main.js
Shortcut handler now calls executeCode() instead of focusing the canvas, with added comments describing the Play behavior.
Play icon color fix
style.css
New CSS rule makes .canvas-stopped-overlay__play .icon inherit the button's text color.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main fix: Ctrl+P now works while the overlay is visible.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lawsie lawsie merged commit ab407c7 into flipcomputing:main Jul 9, 2026
3 checks passed
@lawsie lawsie deleted the bugfix-090726 branch July 9, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant