Feat/asqav audit plugin#3447
Conversation
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
- Add _depth and _max_depth parameters (default 50) to _sync_execution and sync_node_execution
- Raise FlyteAssertion when nesting exceeds limit instead of crashing with RecursionError
- Add unit tests verifying depth guard and regression safety
Fixes #7338
Signed-off-by: Abhishek Shinde <norizzabhii@gmail.com>
Implements an decorator (ClassDecorator pattern) that wraps
Flyte tasks with cryptographically signed receipts at started/finished/failed
lifecycle points using the Asqav SDK. Receipts are rendered as a Flyte Deck
card with verification links.
Closes #7085
Signed-off-by: Abhishek Shinde <norizzabhii@gmail.com>
…ionError" This reverts commit 51ca417. Signed-off-by: Abhishek Shinde <norizzabhii@gmail.com>
10fc010 to
3609235
Compare
|
@falloficaruss great work on this. The architecture is solid, the ClassDecorator pattern matches the flytekit-wandb idiom exactly, and the test suite is genuinely good. As the team behind Asqav, we want to help get this across the finish line. Two things worth fixing before merge, and two smaller follow-ups. P1, agent identity (the main one). The fix is to resolve the agent once, not per call. If you know the agent id up front, use P2, secret resolution order. The code in P3, inconsistent fail-open (smaller). P4, CI coverage (small). None of these are big changes and everything else is in good shape. We are glad to help with any of this directly, let us know. |
Signed-off-by: Abhishek Shinde <norizzabhii@gmail.com>
|
@jagmarques You may review |
|
@falloficaruss this looks great, you addressed all four points cleanly.
From the Asqav side this is in good shape and reads ready for a maintainer pass. Nice work, and thanks for the quick turnaround. |
Tracking issue
Closes flyteorg/flyte#7085
Why are the changes needed?
In regulated environments (finance, healthcare, etc.), teams need provable, tamper-proof records of what AI workflow steps ran, with what data, and what the outputs were. Execution logs alone are insufficient for auditors.
This plugin provides a
@asqav_auditdecorator that wraps Flyte tasks with cryptographically signed receipts at each lifecycle point (started, finished, failed) via the Asqav SDK, enabling verifiable audit trails directly from the Flyte UI.What changes were proposed in this pull request?
New
plugins/flytekit-asqav/plugin package that adds a@asqav_auditdecorator (extendsClassDecorator, same pattern asflytekit-wandb)How was this patch tested?
Tests were added in
tests/test_asqav_tracking.py(9 tests, all pass).The
asqavSDK is patched at the module level — no network calls.Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link