Improve git services & project-langing page#564
Open
Matthbo wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors parts of the git/project backend handling and decomposes the Project Landing page into smaller React components, while also simplifying modal/directory-picker rendering patterns.
Changes:
- Backend: adjust project clone error handling and some minor cleanup in project services/controllers.
- Backend: refactor git credential helper PATH scanning logic.
- Frontend: split
project-landingintoSidebar,Toolbar, andProjectList, and switch modals/directory picker to conditional rendering instead of anisOpenprop.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/org/frankframework/flow/project/ConfigurationProjectServiceTest.java | Updates clone-existing-dir test to match new exception type. |
| src/main/java/org/frankframework/flow/project/ConfigurationProjectService.java | Changes clone/open behavior and exception types; small formatting/cleanup. |
| src/main/java/org/frankframework/flow/project/ConfigurationProjectController.java | Formatting change for clone endpoint invocation. |
| src/main/java/org/frankframework/flow/git/GitCredentialHelper.java | Refactors PATH scanning and exception variable naming. |
| src/main/frontend/app/services/project-service.ts | Uses nullish coalescing when serializing token. |
| src/main/frontend/app/routes/studio/studio.tsx | Fixes hook dependency array (adds navigate). |
| src/main/frontend/app/routes/projectlanding/toolbar.tsx | New extracted toolbar component. |
| src/main/frontend/app/routes/projectlanding/sidebar.tsx | New extracted sidebar component. |
| src/main/frontend/app/routes/projectlanding/project-list.tsx | New extracted project list component. |
| src/main/frontend/app/routes/projectlanding/project-landing.tsx | Uses new subcomponents and conditional rendering for modals/picker. |
| src/main/frontend/app/routes/projectlanding/new-configuration-modal.tsx | Removes isOpen prop and relies on conditional rendering. |
| src/main/frontend/app/routes/projectlanding/clone-configuration-modal.tsx | Removes isOpen prop; adjusts repo-name parsing and picker rendering. |
| src/main/frontend/app/routes/configurations/add-configuration-modal.tsx | Updates directory picker usage to conditional rendering. |
| src/main/frontend/app/components/directory-picker/directory-picker.tsx | Removes isOpen prop; always-internal lifecycle on mount/unmount. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Couple of things I found while exploring how git projects are being handled