Skip to content

Refactor naming#44

Open
Revazashvili wants to merge 4 commits into
frankodoom:masterfrom
Revazashvili:refactor/naming
Open

Refactor naming#44
Revazashvili wants to merge 4 commits into
frankodoom:masterfrom
Revazashvili:refactor/naming

Conversation

@Revazashvili

@Revazashvili Revazashvili commented Dec 2, 2024 •
edited
Loading

Copy link
Copy Markdown
  1. private readonly members should start with lowercase
  2. constants should start with uppercase
  3. local variable naming was inconsistent
  4. fixed tests where private field was retrieved, btw I don't think it's roght to do

@sonarqubecloud

sonarqubecloud Bot commented Dec 2, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Clifftech123

Clifftech123 commented Dec 14, 2024

Copy link
Copy Markdown
Collaborator

@Revazashvili Thank you for this. It will be reviewed. Thank you for contributing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Revazashvili @Clifftech123