Skip to content

chore: Apply security best practices#53

Merged
smockle merged 1 commit into
mainfrom
smockle/supply-chain-defaults
May 29, 2026
Merged

chore: Apply security best practices#53
smockle merged 1 commit into
mainfrom
smockle/supply-chain-defaults

Conversation

@smockle

@smockle smockle commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Apply security best practices: delay updates, use deterministic installs, avoid pull_request_target, review permissions, pin third-party actions, etc.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 28, 2026 13:08
@smockle smockle requested a review from a team as a code owner May 28, 2026 13:08
@smockle smockle requested a review from accessibility-bot May 28, 2026 13:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies small configuration changes intended to reduce supply-chain risk and noisy update churn by adding a short “cooldown” delay before adopting newly released dependency updates.

Changes:

  • Add an .npmrc setting to delay adoption of very recent package releases.
  • Configure Dependabot update entries to use a 3-day cooldown for both npm and GitHub Actions updates.
Show a summary per file
File Description
.npmrc Adds a minimum release age setting to delay consuming very new npm package versions.
.github/dependabot.yml Adds a 3-day cooldown to Dependabot update configurations for npm and GitHub Actions.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@smockle smockle enabled auto-merge May 28, 2026 13:13

@JoyceZhu JoyceZhu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure why Guidepup tests mysteriously started failing here.

@smockle

smockle commented May 29, 2026

Copy link
Copy Markdown
Collaborator Author

Not entirely sure why Guidepup tests mysteriously started failing here.

These tests have always been a little flaky, but they’re really struggling here. I’m going to go ahead and merge this anyways, since:

  1. I can’t think of a reason why this PR would be the source of the failures.
  2. Even if the tests were passing, at this point they’re likely testing Firefox’s native ariaNotify implementation—instead of the polyfill—so not giving much useful signal about the polyfill’s code quality. (Semi-related: Is cross browser support expected? #24 (comment))
  3. This PR’s changes are important.

@smockle smockle disabled auto-merge May 29, 2026 15:05
@smockle smockle merged commit d46ae55 into main May 29, 2026
4 of 13 checks passed
@smockle smockle deleted the smockle/supply-chain-defaults branch May 29, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants