Skip to content

feat(run): adds Worker Pool support to deploy-cloudrun action#585

Open
matbrito wants to merge 18 commits into
google-github-actions:mainfrom
matbrito:main
Open

feat(run): adds Worker Pool support to deploy-cloudrun action#585
matbrito wants to merge 18 commits into
google-github-actions:mainfrom
matbrito:main

Conversation

@matbrito

@matbrito matbrito commented Sep 8, 2025

Copy link
Copy Markdown

Add support do worker pool. Some considerations of this PR are placed below:

  • Worker pool only exists in alpha and beta gcloud components.
  • There is no region flag when using replace command (metadata) in worker pool. Official documentation

@steren

steren commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

Thanks for the PR. I'm supportive of adding worker pool (assuming it has been added on the same model as jobs)

We are looking for someone at Google to review the PR

@iennae iennae left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matbrito Thanks for your initial work on updating this GitHub Action. I haven't finished reviewing, but I wanted to give you some initial feedback. Overall, the approach looks consistent to how jobs/services work.

Comment thread tests/unit/main.test.ts
Comment thread tests/unit/main.test.ts
Comment thread src/main.ts Outdated
Comment thread src/main.ts
Comment thread src/main.ts Outdated
Comment thread src/main.ts Outdated
@iennae iennae changed the title Worker Pool support feat(run): adds Worker Pool support to deploy-cloudrun action Oct 10, 2025
@matbrito

Copy link
Copy Markdown
Author

@matbrito Thanks for your initial work on updating this GitHub Action. I haven't finished reviewing, but I wanted to give you some initial feedback. Overall, the approach looks consistent to how jobs/services work.

Hi @iennae, thanks for your initial review, i've just made some code changes related to the comments you left. I'm totally open to new comments and suggestions

@iennae

iennae commented Oct 15, 2025

Copy link
Copy Markdown
Member

@matbrito thanks, I'll try to revisit by Friday for a last review. Appreciate your patience here!

@bai

bai commented Oct 24, 2025

Copy link
Copy Markdown

A friendly bump just in case it fell through the cracks - supporting this would be awesome 🙏

@matbrito

matbrito commented Nov 1, 2025

Copy link
Copy Markdown
Author

@matbrito thanks, I'll try to revisit by Friday for a last review. Appreciate your patience here!

Hi @iennae did you have time to take a look? I've also fixed some lint issues, is it possible to rerun all workflows?

@dorukgezici

Copy link
Copy Markdown

please? 😂

@bai

bai commented Jan 13, 2026

Copy link
Copy Markdown

I don't want to be that guy and I know we're welcome to use forks since it's OSS, but I still would like to express my frustration in a friendly way: it's unfortunate that developer experience is an afterthought for Google.

You don't even need to implement this, the PR is ready & CLA is signed - click that "Approve Test Suite" button, review, and make a whole bunch of paying customers happier. Just imagine that you're going to spend what - a few hours? - reviewing/merging what's been implemented, and it's going to save so much time everyone that relies on Cloud Run.

I know you're busy, probably have other priorities, quarterly goals, and H12026 roadmap is already signed into action... I just hope that there's a spot in there for supporting existing products.

@phillycheeze

Copy link
Copy Markdown

Is there a fork that implements the worker pools feature? or an alternative action template for it?

We've started to drop a lot of the official google dev tooling because most aren't maintained much anymore.

@kinoppyd

Copy link
Copy Markdown

I’d like to deploy from Actions using the official method, as this feature is already generally available. Is there any plan to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

7 participants