fix: load artifacts from workflow text responses#5969
Conversation
|
Response from ADK Triaging Agent Hello @he-yufeng, thank you for creating this PR! We noticed that a few requirements from our contribution guidelines are missing:
Providing these details will help the maintainers review and merge your PR more efficiently. Thank you! |
1a40481 to
202acdc
Compare
|
I have completed the read-only triage and analysis workflow for PR #5969 resolving workflow tool loops as requested. The detailed findings, architectural audit, and compliance evaluation have been compiled into a premium pull request analysis report which you can access directly here: 📄 PR Analysis Report
Key Summary & Next Steps
|
|
Rechecked the branch locally on current main. The PR description already includes the regression and verification details; current local validation is:
|
|
I rechecked the current red checks on this branch. They do not look caused by this PR diff:
I am leaving the PR code unchanged for now to avoid mixing unrelated main-branch CI cleanup into this focused fix. |
202acdc to
d2f49e6
Compare
|
Rebuilt the branch cleanly on current main, which includes the recent ADC test fix, and kept the PR diff to the two artifact-loading files. Focused tests pass (9 tests), plus ruff, pyink, py_compile, and diff check. |
|
I will read the instruction file for the The complete premium report has been compiled and saved as an artifact which you can view here:
Key Decisions and Open Questions
Summary of Work Done
|
|
Closing this lower-signal artifact text-response PR for now. It has not picked up maintainer review signal, and the ADK queue is too crowded to keep every small isolated branch open. |
Summary
load_artifactsresults that were converted into workflow context textFixes #5967.
Verified
$env:PYTHONPATH=(Resolve-Path src).Path; python -m pytest tests\unittests\tools\test_load_artifacts_tool.py -q->9 passed, 5 warningspython -m pyink --check src\google\adk\tools\load_artifacts_tool.py tests\unittests\tools\test_load_artifacts_tool.py->2 files would be left unchanged$env:PYTHONPATH=(Resolve-Path src).Path; python -m py_compile src\google\adk\tools\load_artifacts_tool.py tests\unittests\tools\test_load_artifacts_tool.py-> passedgit diff --check upstream/main..HEAD-> passedRegression exercised
The new tests cover a workflow text response such as
[workflow_node] `load_artifacts` tool returned result: {'artifact_names': ['invoice.txt'], 'status': 'ok'}and a turn where theload_artifactsfunction response is not the first part. In both cases the request receives a new artifact content turn before the model answers.