bazel: build all Rust tools#3215
Open
mgeisler wants to merge 1 commit into
Open
Conversation
mgeisler
requested review from
djmitche,
michael-kerscher and
qwandor
and removed request for
michael-kerscher
mgeisler
force-pushed
the
bazel-all-tools
branch
from
8f1d7a0 to
cc44c69
Compare
This moves the remaining two tools into Bazel: `i18n-report` and
`mdbook` itself. They are still installed with
cargo xtask install-tools
to make this less disruptive. This will go away as we start using the
`mdbook` rule in Bazel to build the many books.
mgeisler
force-pushed
the
bazel-all-tools
branch
from
cc44c69 to
2fdde9a
Compare
qwandor
reviewed
Jun 17, 2026
| } | ||
|
|
||
| fn install_tools(binstall: bool) -> Result<()> { | ||
| fn install_tools(_binstall: bool) -> Result<()> { |
Collaborator
There was a problem hiding this comment.
Why not remove the binstall parameter, rather than just ignoring it?
Collaborator
Author
There was a problem hiding this comment.
I'm aiming towards removing the whole install-tools, so I figured it would only lead to more churn if I updated the call site.
But I can remove it, no problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the remaining two tools into Bazel:
i18n-reportandmdbookitself. They are still installed withto make this less disruptive. This will go away as we start using the
mdbookrule in Bazel to build the many books.