Include <utility> for std::move in metadata_bytes.h#4018
Open
hjanuschka wants to merge 1 commit into
Open
Conversation
metadata_bytes.h uses std::move in the owning constructor but only includes <cstdint> and <memory>. It happens to compile when <utility> gets pulled in transitively, but breaks under stricter setups (e.g. a libc++ modules build) where std::move must come from its own header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metadata_bytes.h uses std::move in the owning constructor but only includes
<cstdint>and<memory>. It builds fine when<utility>happens to come in transitively, but breaks under a libc++ modules build (hit this rolling into Chromium) where std::move has to be imported from its own header. Adding the include fixes it.