Skip to content

chore: Add pubsub rollback schema sample#34019

Merged
torreypayne merged 1 commit into
mainfrom
add-pubsub-rollback-schema-sample
Jun 10, 2026
Merged

chore: Add pubsub rollback schema sample#34019
torreypayne merged 1 commit into
mainfrom
add-pubsub-rollback-schema-sample

Conversation

@torreypayne

Copy link
Copy Markdown
Member

Adds new samples and acceptance tests for Pub/Sub schema evolution features, mirroring the equivalent changes in Java (googleapis/java-pubsub#1469).

@torreypayne torreypayne requested review from a team and yoshi-approver as code owners June 5, 2026 18:29
@snippet-bot

snippet-bot Bot commented Jun 5, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@aandreassa aandreassa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! Can you please make sure the tests passes? (unrelated, but I wonder if it is just a flaky thing).

You can retry by adding kokoro:force-run label to this PR and it will update eventually.

@torreypayne torreypayne added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2026
@torreypayne torreypayne force-pushed the add-pubsub-rollback-schema-sample branch 3 times, most recently from 01e1838 to 80e1a9b Compare June 9, 2026 20:36
@torreypayne torreypayne requested a review from aandreassa June 9, 2026 21:49
@torreypayne

Copy link
Copy Markdown
Member Author

It looks great! Can you please make sure the tests passes? (unrelated, but I wonder if it is just a flaky thing).

You can retry by adding kokoro:force-run label to this PR and it will update eventually.

@aandreassa I landed the fix to the flaky tests and rebased; builds are green!

@aandreassa aandreassa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo! LGTM

@aandreassa

Copy link
Copy Markdown
Contributor

You should see a similar case in this PR when merging (i.e. difference in title vs commit text).

We do chore for samples as they don't need an actual publication to Rubygems.

@torreypayne torreypayne force-pushed the add-pubsub-rollback-schema-sample branch from 80e1a9b to dfa85f2 Compare June 10, 2026 18:56
@torreypayne

Copy link
Copy Markdown
Member Author

You should see a similar case in this PR when merging (i.e. difference in title vs commit text).

We do chore for samples as they don't need an actual publication to Rubygems.

Updated the commit message to be chore(...)! Going to merge

@torreypayne torreypayne merged commit 4f77a3d into main Jun 10, 2026
17 checks passed
@torreypayne torreypayne deleted the add-pubsub-rollback-schema-sample branch June 10, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants