Upgrade Netty to 4.1.135#12854
Merged
Merged
Conversation
S2ATrustManager now needs to implement X509ExtendedTrustManager because Netty is now doing hostname verification itself if the trust manager is not extended (netty/netty@09e72c4fd8). S2A didn't need to be extended because it received the desired hostname to verify from its constructor, so doesn't need to look it up in SSLSocket/SSLEngine. NettyClientTransportTest is seeing a different failure now because the server is no longer failing the RPC before sending the response headers (netty/netty@b831454889).
kannanjgithub
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S2ATrustManager now needs to implement X509ExtendedTrustManager because Netty is now doing hostname verification itself if the trust manager is not extended (netty/netty@09e72c4fd8). S2A didn't need to be extended because it received the desired hostname to verify from its constructor, so doesn't need to look it up in SSLSocket/SSLEngine.
NettyClientTransportTest is seeing a different failure now because the server is no longer failing the RPC before sending the response headers (netty/netty@b831454889).
CC @ran-su