Addition of MonadReader like interface for StatefulGen#196
Draft
lehins wants to merge 1 commit into
Draft
Conversation
Contributor
|
That's great! I played with code a bit. Few observations. class (R.StatefulGen g m) => MonadStatefulGen g m | m -> g where
askGen :: m g
default askGen :: (MonadReader env m, HasGenEnv env g) => m g
askGen = ...
localGenM :: (g -> m g) -> m a -> m a
default localGenM :: (MonadReader env m, HasGenEnv env g) => (g -> m g) -> m a -> m a
localGenM = ...Also I don't think newtype Rand a = Rand (State SplitMix a)Such type could obviously be instance of DerivingViaI have unreasonable fondness of DerivingVia so I checked whether it possible to use it too define instances. It turns out yet. newtype ViaReader env m a = ViaReader (m a)
deriving newtype (Functor, Applicative, Monad)
deriving newtype instance MonadReader env m => MonadReader env (ViaReader env m)
deriving newtype instance R.StatefulGen g m => R.StatefulGen g (ViaReader env m)
instance (MonadReader env m, HasGenEnv env g, R.StatefulGen g m) =>
MonadStatefulGen g (ViaReader env m)
deriving via ViaReader env (Lazy.StateT s m)
instance ( R.StatefulGen g (Lazy.StateT s m)
, MonadReader env m
, HasGenEnv env g
) => MonadStatefulGen g (Lazy.StateT s m)
Also I didn't checked whether it actually works but it does compile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.