Skip to content

docs: Remove "Building an analytics funnel"#8758

Merged
mikehardy merged 2 commits into
invertase:mainfrom
swrobel:patch-1
Jun 22, 2026
Merged

docs: Remove "Building an analytics funnel"#8758
mikehardy merged 2 commits into
invertase:mainfrom
swrobel:patch-1

Conversation

@swrobel

@swrobel swrobel commented Nov 16, 2025

Copy link
Copy Markdown
Contributor

Description

The advice in the linked post is out of date. GA4 has the ability to filter for specific screen_view events in each funnel step.

@vercel

vercel Bot commented Nov 16, 2025

Copy link
Copy Markdown

@swrobel is attempting to deploy a commit to the Invertase Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant

CLAassistant commented Nov 16, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@swrobel swrobel changed the title [Docs] Remove "Building an analytics funnel" docs: Remove "Building an analytics funnel" Nov 16, 2025
@mikehardy mikehardy force-pushed the main branch 4 times, most recently from 38a52cd to 7af280b Compare December 8, 2025 20:10
@github-actions

github-actions Bot commented Jan 5, 2026

Copy link
Copy Markdown

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions Bot added the Stale label Jan 5, 2026
@swrobel

swrobel commented Jan 5, 2026

Copy link
Copy Markdown
Contributor Author

@mikehardy sorry if there's someone else I should ping, but you're the only maintainer I'm familiar with (thanks for all you do!)

@mikehardy

Copy link
Copy Markdown
Collaborator

Indeed - this one is queued for review, just dormant a bit - thanks for your patience

@mikehardy mikehardy added the Workflow: Needs Review Pending feedback or review from a maintainer. label Jan 7, 2026
mikehardy and others added 2 commits June 22, 2026 14:15
Remove orphaned Gatsby-era sidebar and screencasts config, drop stale
website gitignore entries, and update module scaffolding instructions
for docs.page.
The advice is out of date. GA4 has the ability to filter for specific screen_view events in each funnel step.
@mikehardy

Copy link
Copy Markdown
Collaborator

This became quite the odyssey 😅 - we're in the process of a major refactor of the repository and part of it was fully overhauling the docs - your PR still had merit though, even in the overhauled docs site we still had this as part of our navigation bar - I've updated the PR to match current docs site (along with a commit that fixes a few leftover files from the conversion I did), and it should be good to go

Thanks again

@mikehardy

Copy link
Copy Markdown
Collaborator

all docs related CI checks have passed

@mikehardy mikehardy removed Workflow: Needs Review Pending feedback or review from a maintainer. Needs Attention labels Jun 22, 2026
@mikehardy mikehardy merged commit ced0325 into invertase:main Jun 22, 2026
19 of 20 checks passed
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.60%. Comparing base (3a60901) to head (5876519).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8758   +/-   ##
=========================================
  Coverage     59.60%   59.60%           
  Complexity     1602     1602           
=========================================
  Files           392      392           
  Lines         24774    24774           
  Branches       4530     4497   -33     
=========================================
  Hits          14764    14764           
+ Misses         9270     9230   -40     
- Partials        740      780   +40     
Flag Coverage Δ
android-native 48.55% <ø> (ø)
e2e-ts-android 48.55% <ø> (ø)
e2e-ts-macos 25.65% <ø> (ø)
jest 62.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants