Skip to content

Fix quoted bindings for non-PDO connections #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itsgoingd merged 2 commits into from
Jun 23, 2026
+3 −4
Merged

Fix quoted bindings for non-PDO connections #754

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93bd835
quote bindings for non-PDO connections
FeBe95 Feb 8, 2026
a686c4d
Updated comment.
itsgoingd Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Clockwork/DataSource/EloquentDataSource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,10 +310,9 @@ protected function quoteBinding($binding, $connection)

$pdo = $connection->getPdo();

if ($pdo === null) return;

if ($pdo->getAttribute(\PDO::ATTR_DRIVER_NAME) === 'odbc' || $pdo->getAttribute(\PDO::ATTR_DRIVER_NAME) === 'crate') {
// PDO_ODBC and PDO Crate driver doesn't support the quote method, apply simple MSSQL style quoting instead - Crate sometimes uses a object as a binding - for json support
// In case of non-PDO connections or known drivers without quote support (ODBC, Crate), we apply our own simple MSSQL style quoting instead.
// Some drivers use object bindings (eg. Crate), in this case we try to JSON encode the value.
if ($pdo === null || $pdo->getAttribute(\PDO::ATTR_DRIVER_NAME) === 'odbc' || $pdo->getAttribute(\PDO::ATTR_DRIVER_NAME) === 'crate') {
$binding = is_object($binding) ? json_encode($binding) : $binding;
return "'" . str_replace("'", "''", $binding) . "'";
}
Expand Down