chore: improve devbox maintenance path#2849
Open
otjdiepluong wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens Devbox’s handling of Nix “marked as insecure” failures by avoiding a potential panic when the expected Package <name> pattern is missing, and adds a regression test intended to cover that edge case.
Changes:
- Add a guard in
IsExitErrorInsecurePackageto avoid indexing into an empty regex match. - Add a new unit test intended to simulate an insecure-package stderr that lacks the
Package <name>prefix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/nix/nix.go | Adds a defensive check to prevent an out-of-range access when parsing insecure-package errors. |
| internal/nix/nix_test.go | Adds a test for the missing-package-name edge case (currently not correctly capturing stderr). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+77
to
+81
| cmd := exec.Command("sh", "-c", `echo "error: something is marked as insecure, refusing to evaluate." >&2; exit 1`) | ||
| err := cmd.Run() | ||
| if err == nil { | ||
| t.Fatal("expected a command error") | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Notes: