Skip to content

Fix endless update when MAC is empty in AllowedAddressPairs#853

Open
chenwng wants to merge 1 commit into
k-orc:mainfrom
chenwng:fix-empty-mac
Open

Fix endless update when MAC is empty in AllowedAddressPairs#853
chenwng wants to merge 1 commit into
k-orc:mainfrom
chenwng:fix-empty-mac

Conversation

@chenwng

@chenwng chenwng commented Jul 16, 2026

Copy link
Copy Markdown

This PR refines the check of AllowedAddressPairs between resource spec in ORC and actual port state in OpenStack to avoid endless update.

Close #852

@github-actions github-actions Bot added the semver:patch No API change label Jul 17, 2026

@mandre mandre left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you add new cases to handleAllowedAddressPairsUpdate() to also test when we do not set a MAC address?

@chenwng

chenwng commented Jul 17, 2026

Copy link
Copy Markdown
Author

@mandre I updated the test cases, please review it again.

@dlaw4608

dlaw4608 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

nice one @chenwng, test passes locally as well , LGTM,

@winiciusallan winiciusallan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @chenwng!

@mandre
mandre added this pull request to the merge queue Jul 21, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 21, 2026
@mandre

mandre commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

@dlaw4608 it looks like the gazpacho CI failed because the roleassignment-dependency test is racy in how it checks the project still exists. See how other similar tests use CEL validations instead.

@dlaw4608

Copy link
Copy Markdown
Contributor

@dlaw4608 it looks like the gazpacho CI failed because the roleassignment-dependency test is racy in how it checks the project still exists. See how other similar tests use CEL validations instead.

PR created, I changed assertion-02.yaml from how the old assertion checked status.conditions, which races with the Project controller updating them during its own deletion flow. Now it it race-free because it only check immutable facts similar to how CEL expressions are used in securitygroup-dependency test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:patch No API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port controller continues updating port when MAC address in AllowedAddressPairs is empty

4 participants