Fix endless update when MAC is empty in AllowedAddressPairs#853
Conversation
mandre
left a comment
There was a problem hiding this comment.
Looks good. Could you add new cases to handleAllowedAddressPairsUpdate() to also test when we do not set a MAC address?
|
@mandre I updated the test cases, please review it again. |
|
nice one @chenwng, test passes locally as well , LGTM, |
|
@dlaw4608 it looks like the gazpacho CI failed because the |
PR created, I changed assertion-02.yaml from how the old assertion checked status.conditions, which races with the Project controller updating them during its own deletion flow. Now it it race-free because it only check immutable facts similar to how CEL expressions are used in securitygroup-dependency test. |
This PR refines the check of AllowedAddressPairs between resource spec in ORC and actual port state in OpenStack to avoid endless update.
Close #852