-
Notifications
You must be signed in to change notification settings - Fork 201
fix(docs): align sidebar content vertically and improved responsiveness #1092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
21018b8
595c49e
40cc8d7
e2b566c
ca98b28
e5d942e
dc92ae6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These changes affect the styling for images. Why were these changes made? 🤔
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This fixes a readability issue on mobile view. Before, floating these images at 40% width forced the text next to it into a tiny, unreadable column and caused horizontal scrolling. Setting them to 100% width and removing the float on small screens makes them stack neatly and fixes the overflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain what these changes are and why they are needed? My understanding is that these affect the scrollbar, but I'm not sure how that's related to the sidebar issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I restricted the custom scrollbars to desktop only. On mobile, forcing custom webkit scrollbars makes them stay permanently visible instead of auto-hiding like normal touch scrollbars do. It was eating up screen space and adding to the horizontal overflow issues on smaller viewports.