Skip to content

[Merged by Bors] - feat(NumberTheory/Primorial): a few simple facts#40980

Closed
thefundamentaltheor3m wants to merge 6 commits into
leanprover-community:masterfrom
thefundamentaltheor3m:primorial-edits
Closed

[Merged by Bors] - feat(NumberTheory/Primorial): a few simple facts#40980
thefundamentaltheor3m wants to merge 6 commits into
leanprover-community:masterfrom
thefundamentaltheor3m:primorial-edits

Conversation

@thefundamentaltheor3m

Copy link
Copy Markdown
Collaborator

We prove

  • the primorial is squarefree
  • the prime factors of the primorial are precisely primesLE

We also add that it is non-zero (mere convenience API).


Open in Gitpod

@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Jun 24, 2026
@github-actions

Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

PR summary ec26b4ff6d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ primeFactors_primorial
+ primorial_ne_zero
+ squarefree_primorial

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit ec26b4f).

  • +3 new declarations
  • −0 removed declarations
+primeFactors_primorial
+primorial_ne_zero
+squarefree_primorial

No changes to strong technical debt.

No changes to weak technical debt.

Current commit ec26b4ff6d
Reference commit 62dc8f267e

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Jun 24, 2026
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@thefundamentaltheor3m thefundamentaltheor3m changed the title feat(NumberTheory/Primorial): A few simple facts feat(NumberTheory/Primorial): a few simple facts Jun 24, 2026

@loefflerd loefflerd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor naming issues + golfs

maintainer delegate

Comment thread Mathlib/NumberTheory/Primorial.lean Outdated
Comment thread Mathlib/NumberTheory/Primorial.lean Outdated
Comment thread Mathlib/NumberTheory/Primorial.lean Outdated
Comment thread Mathlib/NumberTheory/Primorial.lean Outdated
@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by loefflerd.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 27, 2026
Comment thread Mathlib/NumberTheory/Primorial.lean Outdated
thefundamentaltheor3m and others added 5 commits June 27, 2026 12:45
Co-authored-by: David Loeffler <d.loeffler.01@cantab.net>
Co-authored-by: David Loeffler <d.loeffler.01@cantab.net>
Co-authored-by: David Loeffler <d.loeffler.01@cantab.net>
Co-authored-by: Bhavik Mehta <bhavikmehta8@gmail.com>
@ocfnash

ocfnash commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Jun 30, 2026
@mathlib-triage mathlib-triage Bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 30, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jun 30, 2026
We prove
- the primorial is squarefree
- the prime factors of the primorial are precisely `primesLE`

We also add that it is non-zero (mere convenience API).

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: Oliver Nash <7734364+ocfnash@users.noreply.github.com>
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Jun 30, 2026
@mathlib-bors

mathlib-bors Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title feat(NumberTheory/Primorial): a few simple facts [Merged by Bors] - feat(NumberTheory/Primorial): a few simple facts Jun 30, 2026
@mathlib-bors mathlib-bors Bot closed this Jun 30, 2026
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Jul 4, 2026
…y#40980)

We prove
- the primorial is squarefree
- the prime factors of the primorial are precisely `primesLE`

We also add that it is non-zero (mere convenience API).

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: Oliver Nash <7734364+ocfnash@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants