chore: remove unused linter.unusedVariables exception#41003
Open
felixpernegger wants to merge 1 commit into
Open
chore: remove unused linter.unusedVariables exception#41003felixpernegger wants to merge 1 commit into
linter.unusedVariables exception#41003felixpernegger wants to merge 1 commit into
Conversation
PR summary 27cb1e6cabImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
Contributor
Author
|
easy |
grunweg
reviewed
Jun 25, 2026
grunweg
left a comment
Contributor
There was a problem hiding this comment.
Thanks - just a small comment.
| rfl | ||
|
|
||
| set_option linter.unusedVariables false in | ||
| /- We name `hcycl` so it can be used as a named argument, but this is unused in the declaration |
Contributor
There was a problem hiding this comment.
Can you keep the first part of the comment, please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like at some point the option was changed to allowed name instances, so this works now. (This is the only instance of the option in mathlib where we can remove it)