Skip to content

chore: remove unused linter.unusedVariables exception#41003

Open
felixpernegger wants to merge 1 commit into
leanprover-community:masterfrom
felixpernegger:unusedvarno
Open

chore: remove unused linter.unusedVariables exception#41003
felixpernegger wants to merge 1 commit into
leanprover-community:masterfrom
felixpernegger:unusedvarno

Conversation

@felixpernegger

Copy link
Copy Markdown
Contributor

Seems like at some point the option was changed to allowed name instances, so this works now. (This is the only instance of the option in mathlib where we can remove it)


Open in Gitpod

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

PR summary 27cb1e6cab

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 27cb1e6).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 27cb1e6cab
Reference commit 8b62164d80

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Jun 24, 2026
@felixpernegger

Copy link
Copy Markdown
Contributor Author

easy

@github-actions github-actions Bot added the easy < 20s of review time. See the lifecycle page for guidelines. label Jun 24, 2026

@grunweg grunweg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - just a small comment.

rfl

set_option linter.unusedVariables false in
/- We name `hcycl` so it can be used as a named argument, but this is unused in the declaration

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep the first part of the comment, please?

@grunweg grunweg added the awaiting-author A reviewer has asked the author a question or requested changes. label Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes. easy < 20s of review time. See the lifecycle page for guidelines. t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants