Skip to content

[Merged by Bors] - feat: a submodule disjoint from a coFG module is FG#41008

Closed
ADedecker wants to merge 2 commits into
leanprover-community:masterfrom
ADedecker:AD_fg_of_disjoint_cofg
Closed

[Merged by Bors] - feat: a submodule disjoint from a coFG module is FG#41008
ADedecker wants to merge 2 commits into
leanprover-community:masterfrom
ADedecker:AD_fg_of_disjoint_cofg

Conversation

@ADedecker

@ADedecker ADedecker commented Jun 24, 2026

Copy link
Copy Markdown
Member

... over a noetherian ring.

Also, over an arbitrary ring, a submodule codisjoint from a fg module is cofg.

This is a prerequisite for Fredholm operators.


Open in Gitpod

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

PR summary eb5bbfd7f2

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ CoFG.fg_of_disjoint
+ FG.cofg_of_codisjoint
+ FG.of_disjoint_of_isNoetherian_quotient

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit eb5bbfd).

  • +3 new declarations
  • −0 removed declarations
+Submodule.CoFG.fg_of_disjoint
+Submodule.FG.cofg_of_codisjoint
+Submodule.FG.of_disjoint_of_isNoetherian_quotient

No changes to strong technical debt.

No changes to weak technical debt.

Current commit eb5bbfd7f2
Reference commit b5f56a6314

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-ring-theory Ring theory label Jun 24, 2026
Comment thread Mathlib/RingTheory/Finiteness/Cofinite.lean Outdated
Comment thread Mathlib/RingTheory/Finiteness/Cofinite.lean Outdated
Comment thread Mathlib/RingTheory/Finiteness/Cofinite.lean
@chrisflav chrisflav added the awaiting-author A reviewer has asked the author a question or requested changes. label Jun 24, 2026
Co-authored-by: Christian Merten <christian@merten.dev>
@ADedecker ADedecker removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jun 25, 2026
@chrisflav

Copy link
Copy Markdown
Member

Thanks!
maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by chrisflav.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 25, 2026
@ADedecker ADedecker requested a review from riccardobrasca June 25, 2026 12:01
@riccardobrasca

Copy link
Copy Markdown
Member

Thanks!

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Jun 25, 2026
@mathlib-triage mathlib-triage Bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 25, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jun 25, 2026
... over a noetherian ring.

Also, over an arbitrary ring, a submodule codisjoint from a fg module is cofg.

This is a prerequisite for Fredholm operators.
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Jun 25, 2026
@mathlib-bors

mathlib-bors Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title feat: a submodule disjoint from a coFG module is FG [Merged by Bors] - feat: a submodule disjoint from a coFG module is FG Jun 25, 2026
@mathlib-bors mathlib-bors Bot closed this Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. ready-to-merge This PR has been sent to bors. t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants