fix(backlight): replace Q_ASSERT with error handling and guard division by zero#1091
Open
deepin-wm wants to merge 1 commit into
Open
fix(backlight): replace Q_ASSERT with error handling and guard division by zero#1091deepin-wm wants to merge 1 commit into
deepin-wm wants to merge 1 commit into
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @deepin-wm, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-wm The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
deepin-wm
force-pushed
the
fix/backlight-error-handling
branch
from
8a9e1ff to
34f5a53
Compare
…on by zero Q_ASSERT crashes in release builds. Replace with proper error handling that logs warnings and returns safely. Add division-by-zero guard in brightness() for the case where max_brightness is invalid. WM-29
deepin-wm
force-pushed
the
fix/backlight-error-handling
branch
from
34f5a53 to
4e31b95
Compare
|
TAG Bot New tag: 0.8.14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Q_ASSERT crashes in release builds. Replace with proper error handling that logs warnings and returns safely. Add division-by-zero guard in brightness() for the case where max_brightness is invalid.
Extracted from #1046. Ref: WM-29