Skip to content

Update default.conf.sample to deny dotfile access#31

Open
nemchik wants to merge 2 commits into
mainfrom
deny-dotfile-access
Open

Update default.conf.sample to deny dotfile access#31
nemchik wants to merge 2 commits into
mainfrom
deny-dotfile-access

Conversation

@nemchik
Copy link
Copy Markdown
Member

@nemchik nemchik commented Feb 8, 2026

No description provided.

Signed-off-by: Eric Nemchik <eric@nemchik.com>
@LinuxServer-CI
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@LinuxServer-CI
Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/budge/0.0.9-pkg-408e07ff-dev-3c7df83a2ea69b1e325923c15c9f9e52ba8ddde0-pr-31/index.html
https://ci-tests.linuxserver.io/lspipepr/budge/0.0.9-pkg-408e07ff-dev-3c7df83a2ea69b1e325923c15c9f9e52ba8ddde0-pr-31/shellcheck-result.xml

Tag Passed
amd64-0.0.9-pkg-408e07ff-dev-3c7df83a2ea69b1e325923c15c9f9e52ba8ddde0-pr-31
arm64v8-0.0.9-pkg-408e07ff-dev-3c7df83a2ea69b1e325923c15c9f9e52ba8ddde0-pr-31

Signed-off-by: Eric Nemchik <eric@nemchik.com>
Copilot AI review requested due to automatic review settings May 5, 2026 21:41
@LinuxServer-CI LinuxServer-CI moved this from PRs to PRs Ready For Team Review in Issue & PR Tracker May 5, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the bundled Nginx sample site configuration to block access to dotfiles by default (while carving out an exception for /.well-known), and documents the change in the project changelog.

Changes:

  • Add Nginx rules to allow /.well-known while denying all other dotfile paths.
  • Remove the prior .ht*-only deny block in favor of a broader dotfile deny.
  • Add a changelog entry describing the required user action.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
root/defaults/nginx/site-confs/default.conf.sample Adds /.well-known allow and a general dotfile deny rule; minor formatting change in the /api/ block.
readme-vars.yml Adds a changelog entry instructing existing users to update their Nginx site config for dotfile denial.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +16 to +20
# Allow access to the ".well-known" directory
location ^~ /.well-known {
allow all;
}


location /api/ {
rewrite /foo/(.*) /$1 break;
rewrite /foo/(.*) /$1 break;
@LinuxServer-CI LinuxServer-CI moved this from PRs Ready For Team Review to PRs in Issue & PR Tracker May 5, 2026
@LinuxServer-CI
Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/budge/0.0.9-pkg-4fb0cea9-dev-07873391d007df6482d4f483cede1b83560f21ee-pr-31/index.html
https://ci-tests.linuxserver.io/lspipepr/budge/0.0.9-pkg-4fb0cea9-dev-07873391d007df6482d4f483cede1b83560f21ee-pr-31/shellcheck-result.xml

Tag Passed
amd64-0.0.9-pkg-4fb0cea9-dev-07873391d007df6482d4f483cede1b83560f21ee-pr-31
arm64v8-0.0.9-pkg-4fb0cea9-dev-07873391d007df6482d4f483cede1b83560f21ee-pr-31

@LinuxServer-CI
Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR for commit 30f93d7 :
https://ci-tests.linuxserver.io/lspipepr/budge/0.0.9-pkg-04514f43-dev-30f93d722e965e999eba7d107072754668be67f8-pr-31/index.html
https://ci-tests.linuxserver.io/lspipepr/budge/0.0.9-pkg-04514f43-dev-30f93d722e965e999eba7d107072754668be67f8-pr-31/shellcheck-result.xml

Tag Passed
amd64-0.0.9-pkg-04514f43-dev-30f93d722e965e999eba7d107072754668be67f8-pr-31
arm64v8-0.0.9-pkg-04514f43-dev-30f93d722e965e999eba7d107072754668be67f8-pr-31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants