Made host_tx_rx_test randomized#634
Open
KinzaQamar wants to merge 2 commits into
Open
Conversation
KinzaQamar
requested review from
elliotb-lowrisc,
engdoreis,
marnovandermaas and
ziuziakowska
and removed request for
elliotb-lowrisc and
ziuziakowska
KinzaQamar
force-pushed
the
i2c_host_test_modif
branch
from
1385548 to
7c06242
Compare
KinzaQamar
force-pushed
the
i2c_host_test_modif
branch
from
7c06242 to
babdfc5
Compare
elliotb-lowrisc
approved these changes
Jun 23, 2026
elliotb-lowrisc
left a comment
elliotb-lowrisc
left a comment
Contributor
There was a problem hiding this comment.
Seems good to me, assuming that it has been tested. Just one minor typo
Signed-off-by: Kinza Qamar <kqzaman@lowrisc.org>
KinzaQamar
force-pushed
the
i2c_host_test_modif
branch
from
babdfc5 to
b05f671
Compare
Signed-off-by: Kinza Qamar <kqzaman@lowrisc.org>
KinzaQamar
force-pushed
the
i2c_host_test_modif
branch
from
b05f671 to
b0c08dd
Compare
martin-velay
reviewed
Jul 7, 2026
|
|
||
| // Declare the device_addr as a byte size array because sw_symbol_backdoor_overwrite() expects the | ||
| // data that is going to overwrite the SW symbol to be an array | ||
| local rand bit [7:0] device_addr[1]; |
Contributor
There was a problem hiding this comment.
I think something can go wrong as the address here is 8 bits but the i2c expects 7 bits. Probably better to add a constraint to this variable?
constraint top_chip_dv_i2c_host_tx_rx_vseq::device_addr_c {
device_addr[0] inside {[8'h00 : 8'h7F]};
}| extern function new(string name=""); | ||
| extern task body(); | ||
| extern virtual task dut_init(string reset_kind = "HARD"); | ||
| extern task body(); |
Contributor
There was a problem hiding this comment.
Nit: this change isn't required and it was better before since new and body methods are part of the UVM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now it can read / write multiple bytes on any 7-bit address