fix(start): reconcile instance status against container runtime before trusting it#456
Open
Caesarsage wants to merge 1 commit into
Open
Conversation
…e trusting it Signed-off-by: caesarsage <destinyerhabor6@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
microcks start trusts the cached status: Running in ~/.config/microcks/config. If the container was removed externally (system restart, autoRemove, manual docker rm), the CLI wedges in "already running" with no recovery path.
This adds ContainerExists() to the container client and checks it before trusting the recorded status — a missing container now falls through to the fresh-create path. Also removes a duplicated "Running" check.
Reproduce:
microcks start --name demodocker rm -f demomicrocks start --name demoRelated issue(s)
An issue I ran into while experimenting with VS Code extension on top of the CLI.
LFX Mentorship
#255